This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my experience using valence_nbt in a large project, there are a few areas it could benefit from ergonomically.
This PR contains a couple of these:
Value
to anOption
of one of its variants, which allows you take advantage ofOption
's methods, and in some cases avoid verbose pattern matching (although sometimes the pattern matching solution is the more elegant one).Compound
to get a value of a specific type.Entry
s forCompound
. A common situation is that you want to look for an existing compound or list in another compound and add to it if it exists, or use a new one if it doesn't. This can now be done withcompound.compound_entry("foo").or_default().insert("bar", 42);
. Previously this required verbose pattern matching.