store: fix deadlock caused by conflicting lock order #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRAPH_POOL
is locked beforeGRAPH_CONSOLIDATE
at L102 and L103, L961 and L961sonic/src/store/fst.rs
Lines 102 to 103 in fd7a21b
sonic/src/store/fst.rs
Lines 960 to 961 in fd7a21b
However, their lock order reverses at L200 and L203.
sonic/src/store/fst.rs
Lines 200 to 203 in fd7a21b
This may cause a deadlock:
The patch is to enforce the order for the two locks.