add some error communication & handling to valhalla_ingest_transit
#4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
force-pushed
the
nn-transit-fail-fast
branch
from
e327d24
to
bfe4664
Compare
nilsnolde
commented
Apr 26, 2024
| @@ -169,13 +169,22 @@ std::priority_queue<tile_transit_info_t> select_transit_tiles(const std::string& | |||
| filesystem::recursive_directory_iterator end_file_itr; | |||
| for (; gtfs_feed_itr != end_file_itr; ++gtfs_feed_itr) { | |||
| const auto& feed_path = gtfs_feed_itr->path(); | |||
| if (gtfs_feed_itr->is_directory() && filesystem::is_empty(feed_path)) { | |||
| LOG_ERROR("Feed directory " + feed_path.string() + " is empty"); | |||
| continue; | |||
There was a problem hiding this comment.
might also return and abort building any transit?
kevinkreiser
previously approved these changes
May 8, 2024
chrstnbwnkl
approved these changes
May 10, 2024
ADMUKHE
pushed a commit
to mercedes-benz/valhalla
that referenced
this pull request
Jul 28, 2024
…alhalla#4710) Co-authored-by: Christian <58629404+chrstnbwnkl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4707
just be a bit more communicative to prevent issues like the referenced one.