add error when we fail to find any connection in matrix #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
May 2, 2024
Comment on lines
+248
to
+250
| if (std::all_of(request.matrix().times().begin(), request.matrix().times().end(), | ||
| [](const float& time) { return time == kMaxCost; })) { | ||
| throw valhalla_exception_t(442); |
There was a problem hiding this comment.
I put this check in the serializer so there's no additional code needed in every algorithm and/or so we don't have to add extra logic to handle second passes. the code is the same as for /route when no route is found.
There was a problem hiding this comment.
do we want to throw in case of expansion action? could still be of use when debugging
There was a problem hiding this comment.
But there’s no info at all if nothing is found, I don’t see how that can be useful?
There was a problem hiding this comment.
ah sorry, I thought there'd be an actual expansion still in that case
chrstnbwnkl
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4715