Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API does not handle errors #6

Closed
fhocutt opened this issue Jan 26, 2016 · 2 comments
Closed

API does not handle errors #6

fhocutt opened this issue Jan 26, 2016 · 2 comments

Comments

@fhocutt
Copy link

fhocutt commented Jan 26, 2016

The API should handle common errors with an error code/message or at least a blank result, rather than serving error pages with a HTML stack trace, like this one: http://tools.wmflabs.org/eranbot/plagiabot/api.py?action=suspected_diffs&page_title=%D0%9D%D0%B8%D0%BA%D0%BE%D0%BB%D1%8C%D1%81%D0%BA%D0%B8%D0%B9%20%D0%9D%D0%B8%D0%BA%D0%BE%D0%BB%D0%B0%D0%B9%D0%98%D0%B2%D0%B0%D0%BD%D0%BE%D0%B2%D0%B8%D1%87&report=1

@eranroz
Copy link
Collaborator

eranroz commented Jan 26, 2016

Fixed in 2cbc104.

@kaldari
Copy link

kaldari commented Nov 19, 2016

Looks good to me. This can probably be closed now.

@eranroz eranroz closed this as completed Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants