Added projectile modification section, applies to bow and javelin

[ahnguyen09]

This mod allows users to change how fast and accurate projectiles are. This mod started with trying to enhance bow gameplay.

I could not remove the delay on mouse release, but this is the next best thing. Your released arrows can be like a laser beam without affecting the damage.

I tested with +200% projectileVelMaxCharge and it felt pretty good when you also decrease the variance (increase accuracy)

[ahnguyen09]

Upon further testing, the current code changes all projectiles. So Greydrawfs rocks become bullets, which is not great 😄 . I will have to change to code a little.

[healiha]

@ahnguyen09 You should try changing the Prefix condition to if (Configuration.Current.ProjectileFired.IsEnabled && __instance.m_character.IsPlayer()), it should give the expected result.

[ahnguyen09]

@healiha thank you for the feedback. I figured if the users want to tweak the Greydrawf projectile, they should also be able to. The Greydrawfs could use some help 😄 . The code a bit longer but not a big deal.

[healiha]

@ahnguyen09 Looking at the code, you would have to define a list of names you want it to be applied since this function is called for all Humanoid. Greydwarfs are one thing but Fulings spears being bullet-like... 😅

[ahnguyen09]

@healiha Yeah you are right also rock throw troll, many star Drager archer, and so on... 😨
.... I think I change my mind again. Because with just a slight increase in the enemy projectile. Dodge roll an attack feels much more rewarding.
Since I am conflicted, then it's better to provide an option. the Default is 0 change so it should be fine.

[nxPublic]

Seems like a good thing to have to improve bow gameplay!

[healiha]

I like the idea but it might be even better if we could add an option to change velocity and accuracy bease on current bow level to see a linear improvement.
What do you think?

[ahnguyen09]

@healiha I like that the idea of ramping max velocity with level. It gives you a minor reward as you level up. I look into adding it.

[ahnguyen09]

List of updates:

1. Change mod class name to end with _Patch to conform with existing style
2. Change the namespace of the attack.cs file to conform with existing style
3. removed the constants in the mod class and moved it into configurations
   a. The config is now changes value instead of change percentage increase/decrease
   b. I like this better anyway now that scaling is added.
4. added ability to enable linear scaling of velocity and accuracy based on level
   a. User can now have a lot of customization around projectile scaling (or not)

[healiha]

It looks promising 😃

Remember to mark requested changes as resolved once done ;)

[ahnguyen09]

It looks promising 😃

Remember to mark requested changes as resolved once done ;)

@healiha I think I just resolved it. I am still a little new to Contributing.

[nxPublic]

Please resolve the merge conflicts and add your configuration file changes to the vplusconfig.json.

Everything else seems merge ready to me :)

[ahnguyen09]

@nxPublic I think i resolved it. I do see the conflict when I merge the latest development.

[nxPublic]

I think we need a lot better descriptions on these different configurations, we should also consider to split up the project changes into 2 different main categories, monster projectiles and player projectiles. Hit me up on discord to discuss this if you like :)

[ahnguyen09]

It looks good to me.