Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added email character blacklist #1449

Merged
merged 4 commits into from
Nov 15, 2020
Merged

added email character blacklist #1449

merged 4 commits into from
Nov 15, 2020

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented Sep 30, 2020

This fixes the stale pr #1377

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@rubiin
Copy link
Member Author

rubiin commented Sep 30, 2020

@profnandaa after this is approved , i will work on another pr

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #1449 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1449   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1276     1278    +2     
=======================================
+ Hits         1275     1277    +2     
  Misses          1        1           
Impacted Files Coverage Δ
src/lib/isEmail.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62650b1...ec6534a. Read the comment docs.

@ezkemboi ezkemboi mentioned this pull request Sep 30, 2020
3 tasks
@profnandaa
Copy link
Member

@rubiin -- can fix the merge conflict?
I have opted the repo into hacktoberfest by adding the topic; so I think there's no need to add the labels, right?

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Oct 4, 2020
@rubiin
Copy link
Member Author

rubiin commented Oct 4, 2020

sure , let me do it asap

@rubiin
Copy link
Member Author

rubiin commented Oct 4, 2020

@profnandaa all done

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contrib! 🎉

/cc. @tux-tn @ezkemboi -- please check.

@profnandaa profnandaa added needs-more-review and removed 🧹 needs-update For PRs that need to be updated before landing labels Oct 4, 2020
@rubiin
Copy link
Member Author

rubiin commented Oct 12, 2020

@profnandaa any updates on this

@profnandaa
Copy link
Member

Let's wait for @ezkemboi / @tux-tn review.

@rubiin
Copy link
Member Author

rubiin commented Nov 12, 2020

@ezkemboi @tux-tn

@ezkemboi
Copy link
Member

ezkemboi commented Nov 15, 2020

Reviewing this one @rubiin. Sorry for the delay.

@ezkemboi
Copy link
Member

The changes are solid. Though since this is a fix of stale or clean up, we could have made use of the guidelines below
Maintenance:-PR-Clean-Up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants