-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added email character blacklist #1449
Conversation
@profnandaa after this is approved , i will work on another pr |
Codecov Report
@@ Coverage Diff @@
## master #1449 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1276 1278 +2
=======================================
+ Hits 1275 1277 +2
Misses 1 1
Continue to review full report at Codecov.
|
@rubiin -- can fix the merge conflict? |
sure , let me do it asap |
@profnandaa all done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@profnandaa any updates on this |
Reviewing this one @rubiin. Sorry for the delay. |
The changes are solid. Though since this is a |
This fixes the stale pr #1377
Checklist