-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add isIPRange ipv6 support #1568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1568 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1796 1796
=========================================
Hits 1796 1796
Continue to review full report at Codecov.
|
is there a problem with PR? |
Your PR is probably fine, they are waiting for #1553 before they review any other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot. its my first try to contribute on open source project i will continue to check issues👍🏻👍🏻 |
It's great work for a first time contribution 👏 👏 👏 . Don't hesitate to pick another issue or add a new locale to an existing validator (We have many missing locales in |
Fixes #1567
Checklist