Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isIPRange ipv6 support #1568

Closed
wants to merge 1 commit into from

Conversation

bakyazi
Copy link

@bakyazi bakyazi commented Jan 1, 2021

Fixes #1567

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #1568 (941944d) into master (8831db3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          100       100           
  Lines         1796      1796           
=========================================
  Hits          1796      1796           
Impacted Files Coverage Δ
src/lib/isIPRange.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8831db3...941944d. Read the comment docs.

@bakyazi
Copy link
Author

bakyazi commented Jan 30, 2021

is there a problem with PR?

@renanmontebelo
Copy link
Contributor

Your PR is probably fine, they are waiting for #1553 before they review any other PR.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your PR!

/cc. @ezkemboi @tux-tn

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Thank you @bakyazi for your work !
LGTM but i think the solution provided by #1594 is more complete

@bakyazi
Copy link
Author

bakyazi commented Mar 8, 2021

thanks a lot. its my first try to contribute on open source project i will continue to check issues👍🏻👍🏻

@tux-tn
Copy link
Member

tux-tn commented Mar 8, 2021

thanks a lot. its my first try to contribute on open source project i will continue to check issues👍🏻👍🏻

It's great work for a first time contribution 👏 👏 👏 . Don't hesitate to pick another issue or add a new locale to an existing validator (We have many missing locales in isMobilePhone , isLicensePlate , isTaxID and other validators) and if you have questions or need some help feel free to ask in the gitter chatroom .

@tux-tn
Copy link
Member

tux-tn commented Oct 2, 2021

Hello @bakyazi
It looks like #1594 have fixed the issue your PR is trying to address, closing since duplicate but feel free to try to fix other issues.

@tux-tn tux-tn closed this Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for IPv6 in isIPRange(str)
4 participants