-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features for v1.0.0 #145
Comments
Looks great to me! |
I'd also add #113 |
Does anyone want to do a particular task? Or you'd prefer free pick? |
I will take a look at #113, if thats OK. |
Perfect :) |
All right, since we'll have some breaking changes then I think the best thing we can do is to switch to 1.3.0 version instead of 0.3.0. This will be a clear mark that something changed in the codebase since we'll increment first number in the version. Sounds good? |
I'm not against it, I surely think it's a good idea for in the feature once we've hit 1.0 and stabilized the codebase. |
There are two reasons I thought about jumping from 0.2.0 to 1.3.0:
As far as I know when it comes to versioning the rules are:
So in case we have both new features and breaking changes it seems that the best thing we could do is to go straight to the version 1.3.0. But that's just my explenation :D |
Hi guys. I'm little busy right now. I'll be able to do some tasks in the next week. But in the next few days I will try to simplify the code in #114. |
@paw3lx sure :) No Need to rush :) |
Regarding version numbers; according to semver you would make this jump: 0.2.0 -> 1.0.0 See https://semver.org/#spec-item-8 And I would love to see some documentation on whats different/unique/better compared to fluentvalidation... |
@Jogai , I think you're right with the versioning. Thanks for sharing this :) I'll change the milestone and label then. Regarding docs, I'm not sure whether it's a good idea and what's the point of doing that. It's the developer who decides which library suits more his needs. Both Valit and FV are build completely differently and represent different approaches. But maybe I simply miss something :D |
No strong opinion on this matter, but I agree with you. |
Or just a list of features, or use cases where it's applicable. |
I was quite busy for couple last weeks but I'm back. From what we have I'm going to create 1.0.0-preview1 version. I'll do the same for ASP.NET Core plugin. @paw3lx what's the status on Autofac plugin? Can I help with that somehow? |
Yea, I'm quite busy too. As you probably saw, I added just one integration - RegisterValit(), which register all Valitators as Singletons. Do you have any idea what we can add here? |
That actually a good question :D I though that we could also think about auto discovering validators for nested objects in case it was not passed as |
Version 0.2.0 was released two days ago, o I think we can start thinking about features for next release. If you have any suggestions, please put them in the comments below :)
For a now we'll definitely, add:
The text was updated successfully, but these errors were encountered: