Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features for v1.0.0 #145

Closed
1 task
GooRiOn opened this issue Dec 7, 2017 · 18 comments
Closed
1 task

Features for v1.0.0 #145

GooRiOn opened this issue Dec 7, 2017 · 18 comments
Labels
Milestone

Comments

@GooRiOn
Copy link
Member

GooRiOn commented Dec 7, 2017

Version 0.2.0 was released two days ago, o I think we can start thinking about features for next release. If you have any suggestions, please put them in the comments below :)

For a now we'll definitely, add:

@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 9, 2017

#146
#147
#148

@timdeschryver
Copy link
Collaborator

Looks great to me!

@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 11, 2017

I'd also add #113

@GooRiOn GooRiOn added the 1.0.0 label Dec 13, 2017
@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 17, 2017

Does anyone want to do a particular task? Or you'd prefer free pick?

@timdeschryver
Copy link
Collaborator

I will take a look at #113, if thats OK.

@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 17, 2017

Perfect :)

@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 17, 2017

All right, since we'll have some breaking changes then I think the best thing we can do is to switch to 1.3.0 version instead of 0.3.0. This will be a clear mark that something changed in the codebase since we'll increment first number in the version. Sounds good?

@timdeschryver
Copy link
Collaborator

I'm not against it, I surely think it's a good idea for in the feature once we've hit 1.0 and stabilized the codebase.
For now I would just go to 0.3 or maybe even better 1.0?

@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 17, 2017

There are two reasons I thought about jumping from 0.2.0 to 1.3.0:

  • when I started the project, I didn't think that we'll have this number of features before version 0.3.0 (not saying about 1.0.0) so it could be hard to add new features for next 7 releases until v1
  • 1.0.0 for many folks might looks like the first version

As far as I know when it comes to versioning the rules are:

  • change last number for bug fixing
  • change second number for features
  • change first number for breaking changes

So in case we have both new features and breaking changes it seems that the best thing we could do is to go straight to the version 1.3.0. But that's just my explenation :D

@paw3lx
Copy link
Collaborator

paw3lx commented Dec 17, 2017

Hi guys. I'm little busy right now. I'll be able to do some tasks in the next week. But in the next few days I will try to simplify the code in #114.

@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 17, 2017

@paw3lx sure :) No Need to rush :)

@GooRiOn GooRiOn changed the title Features for v0.3.0 Features for v1.3.0 Dec 18, 2017
@Jogai
Copy link

Jogai commented Jan 5, 2018

Regarding version numbers; according to semver you would make this jump: 0.2.0 -> 1.0.0

See https://semver.org/#spec-item-8

And I would love to see some documentation on whats different/unique/better compared to fluentvalidation...

@GooRiOn
Copy link
Member Author

GooRiOn commented Jan 6, 2018

@Jogai , I think you're right with the versioning. Thanks for sharing this :) I'll change the milestone and label then.

Regarding docs, I'm not sure whether it's a good idea and what's the point of doing that. It's the developer who decides which library suits more his needs. Both Valit and FV are build completely differently and represent different approaches. But maybe I simply miss something :D

@arekbal , @tdeschryver , @paw3lx ?

@timdeschryver
Copy link
Collaborator

No strong opinion on this matter, but I agree with you.
Maybe we could add a Why section?

@Jogai
Copy link

Jogai commented Jan 10, 2018

Or just a list of features, or use cases where it's applicable.

@GooRiOn GooRiOn changed the title Features for v1.3.0 Features for v1.0.0 Jan 15, 2018
@GooRiOn
Copy link
Member Author

GooRiOn commented Jan 28, 2018

I was quite busy for couple last weeks but I'm back. From what we have I'm going to create 1.0.0-preview1 version. I'll do the same for ASP.NET Core plugin.

@paw3lx what's the status on Autofac plugin? Can I help with that somehow?

@paw3lx
Copy link
Collaborator

paw3lx commented Jan 28, 2018

Yea, I'm quite busy too. As you probably saw, I added just one integration - RegisterValit(), which register all Valitators as Singletons. Do you have any idea what we can add here?

@GooRiOn
Copy link
Member Author

GooRiOn commented Jan 29, 2018

That actually a good question :D I though that we could also think about auto discovering validators for nested objects in case it was not passed as IValitator instance inside Ensure or EnsureFor. But I think we should move this discussion to other repo :)

@GooRiOn GooRiOn closed this as completed Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants