Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cluster connection timeout in tests. #269

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

shachlanAmazon
Copy link
Contributor

When running multiple concurrent tests, the clusters might be slow to respond. This change reduces the chance that this will cause a timeout.

Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMD test still flaky,have you looked into it?

@shachlanAmazon
Copy link
Contributor Author

The CI ran before https://github.com/barshaul/babushka/pull/266 was merged

When running multiple concurrent tests, the clusters might be slow to
respond. This change reduces the chance that this will cause a timeout.
@shachlanAmazon shachlanAmazon merged commit dc4a75e into valkey-io:main Jun 13, 2023
@shachlanAmazon shachlanAmazon mentioned this pull request Jun 13, 2023
@shachlanAmazon shachlanAmazon deleted the connection-timeout branch June 13, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants