Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #8 and replace "redis" and "old valkey" with "server" #15

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Revert #8 and replace "redis" and "old valkey" with "server" #15

merged 5 commits into from
Jun 12, 2024

Conversation

mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented Jun 11, 2024 •
edited by aiven-sal
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR reverts #8 with some additional fixes being mostly replacing of "Redis" or "Valkey" with "Server"

@mkmkme
Revert "core: remove mentions to older Redis from error and docstring"
532ab2c 
This reverts commit ebbc1d4.
It also changes the mentions of "valkey 6.2" and "Redis 6.2" to "server 6.2"

Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
@mkmkme
Revert "remove older redis-py versions from deprecated warnings"
7a0a634 
This reverts commit d4074a9.

Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
@mkmkme
Revert "connection: remove a workaround for obsolete Redis version"
366314b 
This reverts commit 506b789.
Also mentions of "Valkey < 6.0.0" are fixed.

Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
@mkmkme
Revert "base: remove the snippet specific to Redis < 6.0"
5dc5a52 
This reverts commit a0e20ea.
Additionally, it replaces "Redis" with "Server" in comments.

Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
@mkmkme
Revert "remove obsolete tests" and "drop skip_if_server_version_lt"
574d6b3 
This commit reverts b0fa7da and c175433 and effectively returns the
tests for the older server versions.

Signed-off-by: Mikhail Koviazin <mikhail.koviazin@aiven.io>
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@aiven-sal aiven-sal merged commit dcdbde3 into valkey-io:main Jun 12, 2024
49 checks passed
@mkmkme mkmkme deleted the mkmkme/get-old-versions-back branch June 12, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiven-sal aiven-sal aiven-sal approved these changes

@ahmedsobeh ahmedsobeh Awaiting requested review from ahmedsobeh ahmedsobeh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkmkme @codecov-commenter @aiven-sal