Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ValkeyModule_DefragModuleString to ValkeyModule_DefragValkeyModuleString #242

Closed
madolson opened this issue Apr 6, 2024 · 0 comments · Fixed by #243
Closed

Rename ValkeyModule_DefragModuleString to ValkeyModule_DefragValkeyModuleString #242

madolson opened this issue Apr 6, 2024 · 0 comments · Fixed by #243
Labels
help wanted External contributions would be appreciated

Comments

@madolson
Copy link
Member

madolson commented Apr 6, 2024

In #194, we removed the Redis modifier from RedisModule_DefragRedisModuleString instead of updating it to Valkey. Since this is describing a ValkeyModuleString, it seems more important to keep valkey in the name. See https://github.com/search?q=repo%3Avalkey-io%2Fvalkey%20ValkeyModule_DefragModuleString&type=code for places we need to update.
@madolson madolson added the help wanted External contributions would be appreciated label Apr 6, 2024
@9bany 9bany mentioned this issue Apr 6, 2024
Merged
zuiderkwast added a commit that referenced this issue Apr 6, 2024
@9bany @zuiderkwast
Rename ValkeyModule_DefragModuleString to ValkeyModule_DefragValkeyMo…
717ec1e 
…duleString (#243)

fixes: #242

---------

Signed-off-by: 0del <bany.y0599@gmail.com>
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
madolson pushed a commit to madolson/valkey that referenced this issue Apr 7, 2024
@9bany @zuiderkwast @madolson
Rename ValkeyModule_DefragModuleString to ValkeyModule_DefragValkeyMo…
7106742 
…duleString (valkey-io#243)

fixes: valkey-io#242

---------

Signed-off-by: 0del <bany.y0599@gmail.com>
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
PatrickJS pushed a commit to PatrickJS/placeholderkv that referenced this issue Apr 24, 2024
@9bany @zuiderkwast @PatrickJS
Rename ValkeyModule_DefragModuleString to ValkeyModule_DefragValkeyMo…
453f7a7 
…duleString (valkey-io#243)

fixes: valkey-io#242

---------

Signed-off-by: 0del <bany.y0599@gmail.com>
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted External contributions would be appreciated
Projects
Valkey 7.2
Status: Backported
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename ValkeyModule_DefragModuleString to ValkeyModule_DefragValkeyModuleString 9bany/valkey
1 participant
@madolson