Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and change variable names in utils/redis_init_script #354

Closed
Tracked by #25
zuiderkwast opened this issue Apr 23, 2024 · 0 comments · Fixed by #357
Closed
Tracked by #25

Rename and change variable names in utils/redis_init_script #354

zuiderkwast opened this issue Apr 23, 2024 · 0 comments · Fixed by #357
Assignees
@hwware
Labels
help wanted External contributions would be appreciated

Comments

@zuiderkwast
Copy link
Contributor

zuiderkwast commented Apr 23, 2024 •
edited
Loading

This is a template file that can be used when installing it in linux manually.

I don't know if it works, but we can rebrand it anyway. Change Redis to Valkey.

After that, we need to update the documentation about it in the doc repo.
This was referenced Apr 23, 2024
Open
Merged
@zuiderkwast zuiderkwast added the help wanted External contributions would be appreciated label Apr 23, 2024
@hwware hwware self-assigned this Apr 23, 2024
@hwware hwware mentioned this issue Apr 23, 2024
Merged
@enjoy-binbin enjoy-binbin linked a pull request Apr 24, 2024 that will close this issue
Rename redis_init_script file and its content #357
Merged
zuiderkwast pushed a commit that referenced this issue Apr 24, 2024
@hwware
Rename redis_init_script file and its content (#357)
d09a59c 
Rename the init script and a related `.tpl` file and rename variable
names inside (redis to valkey). Update variables in
`utils/install_server.sh`.

Fixes #354

Signed-off-by: hwware <wen.hui.ware@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwware hwware

Labels
help wanted External contributions would be appreciated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename redis_init_script file and its content hwware/valkey
2 participants
@zuiderkwast @hwware