Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naming conventions and links should be changed from redis to valkey #388

Closed
simkusr opened this issue Apr 26, 2024 · 2 comments · Fixed by #389
Closed

naming conventions and links should be changed from redis to valkey #388

simkusr opened this issue Apr 26, 2024 · 2 comments · Fixed by #389

Comments

@simkusr
Copy link
Contributor

simkusr commented Apr 26, 2024 •
edited
Loading

Describe the change

Currently in ./00-RELEASENOTES and in other places most links and naming conventions are pointing to Redis. Should be changed to Valkey.

To reproduce

Example, open ./00-RELEASENOTES for more details.

Expected behavior

Links and naming should be for Valkey instead of Redis

Additional information

NULL
@simkusr simkusr mentioned this issue Apr 26, 2024
Merged
@simkusr simkusr changed the title [BUG] in ./00-RELEASENOTES all links and names point to redis [BUG] naming conventions and links should be changed from redis to valkey Apr 26, 2024
@simkusr simkusr changed the title [BUG] naming conventions and links should be changed from redis to valkey naming conventions and links should be changed from redis to valkey Apr 26, 2024
@madolson
Copy link
Member

Hey. We're trying to not just bulk update everything, but carefully going through all the instances of Redis and update it as appropriate. If you would like to help, we would appreciate PRs.

@simkusr
Copy link
Contributor Author

simkusr commented Apr 26, 2024

My idea was to change more in docs, e.g. PR #389, these changes does not affect code as I was thinking to do another pr for others, which are more sofiaticated then readme :)

zuiderkwast added a commit that referenced this issue May 2, 2024
@simkusr @zuiderkwast
Changed links and naming to valkey instead of redis (#389)
68ca258 
This is a minor change where only naming and links now points properly
to valkey.

Fixes #388

---------

Signed-off-by: Rolandas Šimkus <rolandas@simkus.io>
Signed-off-by: simkusr <rolandas.s@wilibox.com>
Signed-off-by: simkusr <rolandas@simkus.io>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Co-authored-by: simkusr <rolandas.s@wilibox.com>
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
PingXie pushed a commit to PingXie/valkey that referenced this issue May 2, 2024
@simkusr @zuiderkwast @PingXie
Changed links and naming to valkey instead of redis (valkey-io#389)
758ecd8 
This is a minor change where only naming and links now points properly
to valkey.

Fixes valkey-io#388

---------

Signed-off-by: Rolandas Šimkus <rolandas@simkus.io>
Signed-off-by: simkusr <rolandas.s@wilibox.com>
Signed-off-by: simkusr <rolandas@simkus.io>
Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Co-authored-by: simkusr <rolandas.s@wilibox.com>
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed links and naming to valkey instead of redis simkusr/valkey
2 participants
@simkusr @madolson