Migrate util.c unit tests to new test framework #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
karthyuom
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #448 +/- ##
============================================
- Coverage 68.43% 68.41% -0.03%
============================================
Files 109 109
Lines 61681 61681
============================================
- Hits 42214 42201 -13
- Misses 19467 19480 +13
|
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
madolson
approved these changes
May 7, 2024
12 tasks
madolson
reviewed
May 13, 2024
| return flag&1; | ||
| } | ||
|
|
||
| int test_reclaimFilePageCache(int argc, char **argv, int flags) { |
There was a problem hiding this comment.
I think we need to move this declaration outside of the ifdef, since we won't be able to build the tests on non-linux machines since it will complain it's not defined.
There was a problem hiding this comment.
Okay, I will take a look.
karthyuom
added a commit
to karthyuom/valkey
that referenced
this pull request
May 13, 2024
This PR migrates all tests related to util into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all tests related to util into new test framework as part of the parent issue #428.