Migrate sds.c unit tests to new test framework. #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't bring in the assertion change in sds.c of #476 here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #478 +/- ##
============================================
+ Coverage 68.91% 69.81% +0.90%
============================================
Files 109 109
Lines 61792 61791 -1
============================================
+ Hits 42581 43142 +561
+ Misses 19211 18649 -562
|
Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com>
madolson
reviewed
May 9, 2024
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
approved these changes
May 9, 2024
12 tasks
karthyuom
pushed a commit
to karthyuom/valkey
that referenced
this pull request
May 13, 2024
This patch migrates all tests in sds.c into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
srgsanky
pushed a commit
to srgsanky/valkey
that referenced
this pull request
May 19, 2024
This patch migrates all tests in sds.c into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch migrates all tests in sds.c into new test framework as part of the parent issue #428.