-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate quicklist unit test to new framework #515
base: unstable
Are you sure you want to change the base?
Conversation
8843235
to
4126c18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #515 +/- ##
============================================
- Coverage 70.70% 70.68% -0.02%
============================================
Files 114 114
Lines 63157 63159 +2
============================================
- Hits 44654 44647 -7
- Misses 18503 18512 +9
|
2a6f11e
to
9790186
Compare
Signed-off-by: artikell <739609084@qq.com>
9790186
to
874491d
Compare
Signed-off-by: artikell <739609084@qq.com>
Signed-off-by: artikell <739609084@qq.com>
Signed-off-by: artikell <739609084@qq.com>
dd26ecc
to
49c20d2
Compare
Signed-off-by: artikell <739609084@qq.com>
…it test Signed-off-by: artikell <739609084@qq.com>
@madolson I need your help to review it. I have broken it down into multiple commitments. Used to assist with code review.
|
@enjoy-binbin @madolson It seems that there are only SERVER_TEST left in quicklist, I want to push this forward. There are more cases in this part. Do we want to merge in batches, or is it more appropriate to merge with one mr? |
I think one PR should be enough, there is no need for more batches, please go ahead, thanks |
Signed-off-by: skyfirelee <739609084@qq.com>
Signed-off-by: artikell <739609084@qq.com>
The conflict has been resolved. Could you kindly review it? Thank you |
It seems that the quicklist is a very troublesome change, and currently PR has attempted to complete the migration of the quicklist. There are several modification points involved:
Although there are many points that need to be discussed.