Add aliases for masteruser and masterauth to primaryuser and primaryauth #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
added
release-notes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #598 +/- ##
============================================
+ Coverage 70.07% 70.19% +0.11%
============================================
Files 110 110
Lines 59991 59992 +1
============================================
+ Hits 42038 42110 +72
+ Misses 17953 17882 -71
|
enjoy-binbin
approved these changes
Jun 4, 2024
PingXie
approved these changes
Jun 4, 2024
hpatro
reviewed
Jun 4, 2024
Sure. |
madolson
added
major-decision-approved
advaMosh
pushed a commit
to advaMosh/valkey
that referenced
this pull request
Jun 10, 2024
…alkey-io#598) Make the one backwards compatible config change we are allowed to replace for removing master from our API. `masterauth` and `masteruser` are still used as an alias, but aren't explicitly referenced. As an addendum to valkey-io#591, it would be good to have this in 8. Given the related PR for updated other references for master, I just updated the ones around this specific change. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Adva Moshkovitz <advamo7@gmail.com>
naglera
pushed a commit
to naglera/placeholderkv
that referenced
this pull request
Jun 10, 2024
…alkey-io#598) Make the one backwards compatible config change we are allowed to replace for removing master from our API. `masterauth` and `masteruser` are still used as an alias, but aren't explicitly referenced. As an addendum to valkey-io#591, it would be good to have this in 8. Given the related PR for updated other references for master, I just updated the ones around this specific change. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the one backwards compatible config change we are allowed to replace for removing master from our API.
masterauthandmasteruserare still used as an alias, but aren't explicitly referenced. As an addendum to #591, it would be good to have this in 8. Given the related PR for updated other references for master, I just updated the ones around this specific change.