For additional compatibility this adds REDIS_CFLAGS and REDIS_LDFLAGS support to MAKEFILE #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
roshkhatri
changed the title
madolson
reviewed
Mar 28, 2024
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
hpatro
approved these changes
Mar 28, 2024
zuiderkwast
approved these changes
Mar 30, 2024
|
Thankyou @zuiderkwast |
gaod
pushed a commit
to gaod/valkey
that referenced
this pull request
Apr 2, 2024
… support to MAKEFILE (valkey-io#66) This resolves (1.viii) from valkey-io#43 > REDIS_FLAGS will be updated to SERVER_FLAGS. Maybe we should also allow REDIS_FLAGS -> SERVER_FLAGS as well, for an extra layer of compatibility. --------- Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Apr 7, 2024
… support to MAKEFILE (valkey-io#66) This resolves (1.viii) from valkey-io#43 > REDIS_FLAGS will be updated to SERVER_FLAGS. Maybe we should also allow REDIS_FLAGS -> SERVER_FLAGS as well, for an extra layer of compatibility. --------- Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
… support to MAKEFILE (valkey-io#66) This resolves (1.viii) from valkey-io#43 > REDIS_FLAGS will be updated to SERVER_FLAGS. Maybe we should also allow REDIS_FLAGS -> SERVER_FLAGS as well, for an extra layer of compatibility. --------- Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves (1.viii) from #43