Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up URLs #29

Closed
clokep opened this issue Oct 5, 2016 · 3 comments · Fixed by #141
Closed

Clean-up URLs #29

clokep opened this issue Oct 5, 2016 · 3 comments · Fixed by #141
Labels
tech debt
Milestone
1.0

Comments

@clokep
Copy link
Collaborator

clokep commented Oct 5, 2016

The URLs we include are kind of a mess:

  • Some use dashes, others underscores
  • None of them have a trailing slash
  • Some are sub-directories, others are not

Theoretically we can just change these if people use names, but we would probably want to include redirects. It could also be nice to use a namespace.
@clokep clokep mentioned this issue Feb 17, 2017
Merged
@9mido
Copy link
Contributor

9mido commented Mar 31, 2021 •
edited
Loading

Wouldn't following this be able to help with the redirecting apsect?

https://stackoverflow.com/questions/14959217/django-url-redirect

https://stackoverflow.com/questions/15706489/redirect-to-named-url-pattern-directly-from-urls-py-in-django

@akx akx added this to the 1.0 milestone Dec 7, 2021
@akx
Copy link
Member

akx commented Dec 7, 2021

1.0 should just drop the "old" URLs (that don't have trailing slashes).

@valberg
Copy link
Collaborator

valberg commented Dec 7, 2021

1.0 should just drop the "old" URLs (that don't have trailing slashes).

Oh yes please!

akx added a commit that referenced this issue Jul 4, 2022
@akx
Clean up URLs
d06b3af 
* URLs require the trailing slash, as is the Django (and allauth) way
* URLs no longer have a hard-coded "two-factor/" prefix; like with allauth, the prefix is left for the `include()`r to decide
* URLs have dashes instead of underscores (like allauth)

Fixes #29
@akx akx mentioned this issue Jul 4, 2022
Merged
akx added a commit that referenced this issue Jul 4, 2022
@akx
Clean up URLs
f5bb6a7 
* URLs require the trailing slash, as is the Django (and allauth) way
* URLs no longer have a hard-coded "two-factor/" prefix; like with allauth, the prefix is left for the `include()`r to decide
* URLs have dashes instead of underscores (like allauth)

Fixes #29
@akx akx closed this as completed in #141 Jul 7, 2022
akx added a commit that referenced this issue Jul 7, 2022
@akx
Clean up URLs
8a2901d 
* URLs require the trailing slash, as is the Django (and allauth) way
* URLs no longer have a hard-coded "two-factor/" prefix; like with allauth, the prefix is left for the `include()`r to decide
* URLs have dashes instead of underscores (like allauth)

Fixes #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Clean up URLs valohai/django-allauth-2fa
4 participants
@valberg @akx @clokep @9mido