Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when an unnamed view hits the middleware. #38

Merged
merged 3 commits into from
Oct 31, 2016
Merged

Fix exception when an unnamed view hits the middleware. #38

merged 3 commits into from
Oct 31, 2016

Conversation

clokep
Copy link
Collaborator

@clokep clokep commented Oct 31, 2016

Hitting an unnamed view currently raises an exception. This should be allowed (and it should reset the login flow).

Fixes #37

@clokep clokep self-assigned this Oct 31, 2016
@clokep clokep mentioned this pull request Oct 31, 2016
Closed
MightySCollins
MightySCollins approved these changes Oct 31, 2016
View reviewed changes
Copy link
Contributor

@MightySCollins MightySCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should fix the problem and nice to see a test for it.

@clokep
Copy link
Collaborator Author

clokep commented Oct 31, 2016

Thanks! 👍

Looks like we're overdue for a release to. I'll do that this week.

@clokep clokep merged commit 8f9cec3 into master Oct 31, 2016
@clokep clokep deleted the unnamed-views branch October 31, 2016 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MightySCollins MightySCollins MightySCollins approved these changes

Assignees

@clokep clokep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @MightySCollins