Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #43 of not forwarding GET parameters when 2fa is enabled #44

Merged
merged 5 commits into from
Dec 29, 2016

Conversation

humrochagf
Copy link
Contributor

No description provided.

@clokep
Copy link
Collaborator

clokep commented Dec 15, 2016

Looks sane at first glance! I'll test this out soon. Thanks for writing a test-case. 👍

@JelteF
Copy link
Contributor

JelteF commented Dec 27, 2016

Any update on this? Would be great to see this annoyance go away.

@clokep clokep self-assigned this Dec 27, 2016
@clokep
Copy link
Collaborator

clokep commented Dec 28, 2016

Sorry for being so slow on this! I'll try to get to this by the end of the week. Thanks for the reminder!

@clokep
Copy link
Collaborator

clokep commented Dec 29, 2016

I tested this manually and it seems to work well! 👍

@clokep clokep merged commit 10ff0f1 into valohai:master Dec 29, 2016
@clokep
Copy link
Collaborator

clokep commented Dec 29, 2016

Thanks! I'm going to do some release note updates and a couple other minor things and do a release for this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants