Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out chunk reading in MultipartUploader for overriding #8

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

akx
Copy link
Member

@akx akx commented Jul 29, 2019

No description provided.

@akx akx added the enhancement New feature or request label Jul 29, 2019
@akx akx requested a review from ruksi July 29, 2019 13:08
@codecov-io
Copy link

codecov-io commented Jul 29, 2019

Codecov Report

Merging #8 into master will decrease coverage by 0.11%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   98.46%   98.34%   -0.12%     
==========================================
  Files          12       12              
  Lines         650      664      +14     
  Branches       69       72       +3     
==========================================
+ Hits          640      653      +13     
  Misses          3        3              
- Partials        7        8       +1
Impacted Files Coverage Δ
hai/boto3_multipart_upload.py 97.1% <100%> (+0.08%) ⬆️
hai_tests/test_multipart_upload.py 96.92% <92.3%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c27f1...c063622. Read the comment docs.

Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ruksi ruksi merged commit 42f98d3 into master Jul 29, 2019
@ruksi ruksi deleted the chunk-func branch July 29, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants