Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better callback-credentials features #13

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Better callback-credentials features #13

merged 2 commits into from
Mar 22, 2022

Conversation

akx
Copy link
Member

@akx akx commented Mar 21, 2022

  • Add the Laituri version to the callback request
  • Allow adding (e.g. Authorization) headers and changing the request method (if you really need to) for the callback request

@akx akx added the type:enhancement New feature or request label Mar 21, 2022
@akx akx requested review from a team, ruksi and magdapoppins and removed request for a team March 21, 2022 15:24
magdapoppins
magdapoppins approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@magdapoppins magdapoppins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magdapoppins magdapoppins merged commit 93da01b into master Mar 22, 2022
@magdapoppins magdapoppins deleted the better-callback branch March 22, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magdapoppins magdapoppins magdapoppins approved these changes

@ruksi ruksi Awaiting requested review from ruksi ruksi was automatically assigned from valohai/dev

Assignees
No one assigned
Labels
type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akx @magdapoppins