Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes & embetterments #15

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Small fixes & embetterments #15

merged 4 commits into from
Mar 23, 2022

Conversation

akx
Copy link
Member

@akx akx commented Mar 22, 2022

  • Makes logging a little less verbose
  • Use shutil.which to find docker (to avoid one needless /usr/bin/env)
  • Ensures docker_logout gets called even if an exception occurs

@akx akx requested review from a team, ruksi and tokkoro and removed request for a team March 22, 2022 14:19
@akx akx added type:bug Something isn't working type:enhancement New feature or request labels Mar 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #15 (0672555) into master (93da01b) will decrease coverage by 0.30%.
The diff coverage is 77.27%.

❗ Current head 0672555 differs from pull request most recent head 7fe70d1. Consider uploading reports for the commit 7fe70d1 to get more accurate results

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   96.49%   96.19%   -0.31%     
==========================================
  Files          15       15              
  Lines         257      263       +6     
  Branches       17       16       -1     
==========================================
+ Hits          248      253       +5     
- Misses          5        6       +1     
  Partials        4        4              
Impacted Files Coverage Δ
laituri_tests/mock_process.py 89.47% <0.00%> (ø)
laituri_tests/test_docker_v1.py 90.00% <57.14%> (-1.67%) ⬇️
laituri/docker/credential_manager/docker_v1.py 100.00% <100.00%> (ø)
laituri/docker/credential_manager/errors.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93da01b...7fe70d1. Read the comment docs.

@akx akx requested review from magdapoppins and removed request for ruksi March 22, 2022 14:47
Copy link

@tokkoro tokkoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022/2022 ✔️

@akx akx merged commit d847c51 into master Mar 23, 2022
@ruksi ruksi deleted the fixurinos branch April 11, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants