Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings module that can be used to configure the library #2

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

ruksi
Copy link
Member

@ruksi ruksi commented Jun 3, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #2 into master will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   94.96%   95.37%   +0.40%     
==========================================
  Files           9       10       +1     
  Lines         159      173      +14     
  Branches        9       11       +2     
==========================================
+ Hits          151      165      +14     
  Misses          5        5              
  Partials        3        3              
Impacted Files Coverage Δ
laituri/__init__.py 100.00% <ø> (ø)
laituri/docker/credential_manager/__init__.py 100.00% <ø> (ø)
...i/docker/credential_manager/credential_managers.py 100.00% <ø> (ø)
laituri/docker/credential_manager/dummy.py 100.00% <ø> (ø)
laituri/docker/credential_manager/errors.py 100.00% <ø> (ø)
laituri_tests/mock_process.py 89.47% <ø> (ø)
laituri/docker/credential_manager/docker_v1.py 100.00% <100.00%> (ø)
laituri/settings.py 100.00% <100.00%> (ø)
laituri_tests/test_credential_managers.py 93.10% <100.00%> (ø)
laituri_tests/test_general.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f64fad...d411c8b. Read the comment docs.

@ruksi
Copy link
Member Author

ruksi commented Jun 3, 2020

self-merging, want to get prototype release out, will revise later if wanted

@ruksi ruksi merged commit b47e823 into master Jun 3, 2020
@ruksi ruksi deleted the settings branch June 3, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants