Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using AWS instance roles for docker login #20

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Allow using AWS instance roles for docker login #20

merged 1 commit into from
Sep 19, 2022

Conversation

magdapoppins
Copy link
Contributor

@magdapoppins magdapoppins commented Sep 14, 2022 •
edited
Loading

If users pass in a role name, check that that instance role is present on the EC2 instance and use it when authenticating to ECR.

@magdapoppins magdapoppins force-pushed the aws-instance-roles branch 5 times, most recently from d3d20cc to 79beee1 Compare September 14, 2022 13:04
@magdapoppins magdapoppins marked this pull request as ready for review September 14, 2022 13:08
akx
akx requested changes Sep 14, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
laituri/docker/credential_manager/ecr_with_role_v1.py Outdated Show resolved Hide resolved
@magdapoppins magdapoppins force-pushed the aws-instance-roles branch 3 times, most recently from 4846cc1 to 9bb089b Compare September 15, 2022 09:38
@magdapoppins magdapoppins force-pushed the aws-instance-roles branch 3 times, most recently from 7038ec3 to 3e66a39 Compare September 15, 2022 10:28
akx
akx requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol embetterment requests

laituri/docker/credential_manager/ecr_with_role_v1.py Outdated Show resolved Hide resolved
laituri/docker/credential_manager/ecr_with_role_v1.py Outdated Show resolved Hide resolved
laituri/docker/credential_manager/ecr_with_role_v1.py Outdated Show resolved Hide resolved
akx
akx approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate a test, but this is okay!

@akx akx merged commit 1cbb437 into master Sep 19, 2022
@akx akx deleted the aws-instance-roles branch September 19, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akx akx akx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magdapoppins @akx