Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry callback support #4

Merged
merged 7 commits into from
Jul 16, 2020
Merged

Add registry callback support #4

merged 7 commits into from
Jul 16, 2020

Conversation

ruksi
Copy link
Member

@ruksi ruksi commented Jul 15, 2020

Support for receiving signed URLs that allow getting Docker registry credentials later.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2020

Codecov Report

Merging #4 into master will increase coverage by 1.31%.
The diff coverage is 96.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   95.37%   96.69%   +1.31%     
==========================================
  Files          10       15       +5     
  Lines         173      242      +69     
  Branches       11       13       +2     
==========================================
+ Hits          165      234      +69     
  Misses          5        5              
  Partials        3        3              
Impacted Files Coverage Δ
laituri_tests/test_docker_v1.py 91.66% <91.66%> (ø)
laituri/docker/credential_manager/__init__.py 100.00% <100.00%> (ø)
...i/docker/credential_manager/credential_managers.py 100.00% <100.00%> (ø)
laituri/docker/credential_manager/docker_v1.py 100.00% <100.00%> (ø)
...ential_manager/registry_credentials_callback_v1.py 100.00% <100.00%> (ø)
laituri/utils/retry.py 100.00% <100.00%> (ø)
laituri_tests/mock_data.py 100.00% <100.00%> (ø)
laituri_tests/test_credential_managers.py 100.00% <100.00%> (+6.89%) ⬆️
...uri_tests/test_registry_credentials_callback_v1.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47e823...6e9bffe. Read the comment docs.

@ruksi ruksi marked this pull request as ready for review July 15, 2020 13:37
@ruksi ruksi requested a review from JuhaKiili July 15, 2020 13:38
@ruksi ruksi merged commit af506be into master Jul 16, 2020
@ruksi ruksi deleted the registry-callback branch July 16, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants