Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline node actions #48

Merged
merged 7 commits into from Jun 16, 2021
Merged

Pipeline node actions #48

merged 7 commits into from Jun 16, 2021

Conversation

akx
Copy link
Member

@akx akx commented Jun 15, 2021 •
edited

No description provided.

@akx akx requested review from a team, ruksi and magdapoppins and removed request for a team June 15, 2021 14:53
@akx akx requested review from JuhaKiili and tokkoro June 15, 2021 14:57
@akx akx force-pushed the node-actions branch 2 times, most recently from 960975a to 8a530a7 Compare June 16, 2021 08:48
@akx akx marked this pull request as ready for review June 16, 2021 08:52
@akx akx requested a review from ruksi June 16, 2021 08:57
ruksi
ruksi approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good refactorings and addition of the node actions

lgtm

@ruksi ruksi merged commit 1f73432 into master Jun 16, 2021
@ruksi ruksi deleted the node-actions branch June 16, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruksi ruksi ruksi approved these changes

@magdapoppins magdapoppins Awaiting requested review from magdapoppins

@JuhaKiili JuhaKiili Awaiting requested review from JuhaKiili

@tokkoro tokkoro Awaiting requested review from tokkoro

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akx @ruksi