Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table sorting arrow is not shown #228

Open
theunreal opened this issue Jul 29, 2016 · 6 comments
Open

Table sorting arrow is not shown #228

theunreal opened this issue Jul 29, 2016 · 6 comments

Comments

@theunreal
Copy link

Why do the sorting arrow like in the demo is not displayed in my app?

No console errors

@wilfredmifsud
Copy link

Do you have FontAwesome installed ? As it renders an icon in the th when you sort up/ down (there is no icon when not sorting)

@Pokom
Copy link

Pokom commented Aug 17, 2016

@wilfredmifsud

It might be worthwhile to consider adding some of these items to the README.md. As awkward as this is to say, it wasn't obvious to me that FontAwesome and Bootstrap we're required to get this to work.

@georgeedwards
Copy link

Was going to open a new issue/feature request, but it seems like this only works with font-awesome, and the generated icon can't be configured - am I right? If so, I think this would be a really useful feature, to avoid the dependency on bootstrap and font-awesome. I for example, would like the icons to be generated as <i class="material-icons">arrow_drop_down</i> and <i class="material-icons">arrow_drop_up</i> so I can use Google Icons which I use across my project already.

@jeff-jacobs
Copy link

I am going to also say the ability to configure the sort icon is kind of a must. I shouldn't have to load the entire font-awesome file just for a couple icons. I built my own font icon library with Fontello for this exact reason, and the fact that I can't use my own icons is kind of a problem.

@Pokom
Copy link

Pokom commented Dec 13, 2016

@jeffaxial
While this isn't an ideal solution, you can also just use the same classnames as the respective font-awesome icon and have those classes reference your set of icons. I think the true feature request is to have control to configure the icon classes for the table component, which would be ideal in your situation.

@jeff-jacobs
Copy link

@Pokom Yeah, I ended up adding the fontawesome classes to my fontello icon list classes. It's kind of dirty, but it gets the job done for now. But yes, the real request is to have control over those classes/active states. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants