Component modals #1181
Labels
Comments
|
This would be very nice indeed! |
|
work in progress |
|
+1 |
1 similar comment
|
+1 |
valorkin
pushed a commit
that referenced
this issue
Jul 18, 2017
fixes #1998 fixes #1995 fixes #1830 fixes #1181 fixes #579 * feat(modal): modal service wip * feat(modal): wip, add close buttons attribute support, add ability to open modaol with component * feat(modal): add config, move creating of loader to constructor, add demo * fix(modal): fix service path * fix(modal): fix api-docs * fix(modal): fix scroll on modals created by service, add docs * feat(modal): wip, add BsModalService.show output obj * refactor(modal): change inner component getter * feat(modal): add BsModalRef and docs * feat(modal): remove data-attributes, return BsModalRef, update docs * feat(modal): add docs for BsModalService, BsModalRef, update demo * feat(modal): add bs4 support * feat(modal): keep focus inside a modal * chore(modals): small refactoring (#2128) * chore(modals): simplify service (#2130) * chore(modal): view container ref made optional for component loader (#2133) * fix(modal): fix backdrop flickering * fix(modal): fix backdrop click on the left/right sides, add class option * feat(modals): nested modals wip * fix(modal): fix multiple hide() call * fix(modal): fix multiple backdrop clicks, fix padding * fix(modal): fixed padding * fix(modal): fix page flickering * feat(modal): add isAnimated support, add service section to demo * fix(test): fix popover and tyepahead unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a couple of places in different components, where I open similar modal (for instance, 'settings')
Now I have to declare independent component that I insert everywhere, get access to it with
ViewChildand proxyshow()function tobsModaldirective. But, imho, it's not best way to do this.Is there a way to open component modals as we could in
ui-bootstrap:https://angular-ui.github.io/bootstrap/#/modal : $ctrl.openComponentModal section
The text was updated successfully, but these errors were encountered: