Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(modals): small refactoring #2128

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Conversation

valorkin
Copy link
Member

No description provided.

@IlyaSurmay IlyaSurmay merged commit 91f06a9 into feat-modal-service Jun 26, 2017
@IlyaSurmay IlyaSurmay deleted the feat-modal2 branch June 26, 2017 14:08
valorkin pushed a commit that referenced this pull request Jul 18, 2017
fixes #1998
fixes #1995
fixes #1830
fixes #1181
fixes #579 

* feat(modal): modal service wip

* feat(modal): wip, add close buttons attribute support, add ability to open modaol with component

* feat(modal): add config, move creating of loader to constructor, add demo

* fix(modal): fix service path

* fix(modal): fix api-docs

* fix(modal): fix scroll on modals created by service, add docs

* feat(modal): wip, add BsModalService.show output obj

* refactor(modal): change inner component getter

* feat(modal): add BsModalRef and docs

* feat(modal): remove data-attributes, return BsModalRef, update docs

* feat(modal): add docs for BsModalService, BsModalRef, update demo

* feat(modal): add bs4 support

* feat(modal): keep focus inside a modal

* chore(modals): small refactoring (#2128)

* chore(modals): simplify service (#2130)

* chore(modal): view container ref made optional for component loader (#2133)

* fix(modal): fix backdrop flickering

* fix(modal): fix backdrop click on the left/right sides, add class option

* feat(modals): nested modals wip

* fix(modal): fix multiple hide() call

* fix(modal): fix multiple backdrop clicks, fix padding

* fix(modal): fixed padding

* fix(modal): fix page flickering

* feat(modal): add isAnimated support, add service section to demo

* fix(test): fix popover and tyepahead unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants