Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Dynamic modal #1998

Closed
x1unix opened this issue May 24, 2017 · 2 comments · Fixed by #2047
Closed

[Request] Dynamic modal #1998

x1unix opened this issue May 24, 2017 · 2 comments · Fixed by #2047

Comments

@x1unix
Copy link

x1unix commented May 24, 2017

Please add feature to allow to create dynamic modal windows throw TypeScript code, like ng-bootstrap at angular 1.x

@larryspace
Copy link

larryspace commented May 25, 2017

+1

I was trying to achieve this for a long time, has not found the right way.

Now do this:

const modalComponentFactory = this.componentFactoryResolver.resolveComponentFactory(ModalComponent); const _componentRef = this.modal.createComponent(modalComponentFactory); _componentRef.instance['_componentRef'] = _componentRef;`

this._componentRef.destroy();

But now stuck in a place, do not know how to create a modal window to the body node, and how to achieve the modal window component of the transfer

@IlyaSurmay
Copy link
Contributor

Work is in progress #2047

valorkin pushed a commit that referenced this issue Jul 18, 2017
fixes #1998
fixes #1995
fixes #1830
fixes #1181
fixes #579 

* feat(modal): modal service wip

* feat(modal): wip, add close buttons attribute support, add ability to open modaol with component

* feat(modal): add config, move creating of loader to constructor, add demo

* fix(modal): fix service path

* fix(modal): fix api-docs

* fix(modal): fix scroll on modals created by service, add docs

* feat(modal): wip, add BsModalService.show output obj

* refactor(modal): change inner component getter

* feat(modal): add BsModalRef and docs

* feat(modal): remove data-attributes, return BsModalRef, update docs

* feat(modal): add docs for BsModalService, BsModalRef, update demo

* feat(modal): add bs4 support

* feat(modal): keep focus inside a modal

* chore(modals): small refactoring (#2128)

* chore(modals): simplify service (#2130)

* chore(modal): view container ref made optional for component loader (#2133)

* fix(modal): fix backdrop flickering

* fix(modal): fix backdrop click on the left/right sides, add class option

* feat(modals): nested modals wip

* fix(modal): fix multiple hide() call

* fix(modal): fix multiple backdrop clicks, fix padding

* fix(modal): fixed padding

* fix(modal): fix page flickering

* feat(modal): add isAnimated support, add service section to demo

* fix(test): fix popover and tyepahead unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants