Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datepicker): add ivy support #5268

Merged
merged 2 commits into from
Jun 19, 2019
Merged

feat(datepicker): add ivy support #5268

merged 2 commits into from
Jun 19, 2019

Conversation

Domainv
Copy link
Contributor

@Domainv Domainv commented Jun 12, 2019

Steps to reproduce:
ng new hello-ivy --enable-ivy
npm i
npm i ngx-bootstrap@next
npm run build

Closes #5257

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@Domainv Domainv force-pushed the feat-datepicker-ivy branch 8 times, most recently from fd7da10 to fb89f24 Compare June 13, 2019 12:47
@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #5268 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5268   +/-   ##
============================================
  Coverage        51.04%   51.04%           
============================================
  Files                3        3           
  Lines               96       96           
  Branches            17       17           
============================================
  Hits                49       49           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 669d7e1...fb89f24. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #5268 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5268   +/-   ##
============================================
  Coverage        51.04%   51.04%           
============================================
  Files                3        3           
  Lines               96       96           
  Branches            17       17           
============================================
  Hits                49       49           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 669d7e1...2d8dfef. Read the comment docs.

@ludmilanesvitiy
Copy link
Contributor

import { BsDatepickerModule } from 'ngx-bootstrap/datepicker'; - works well
but with import { BsDatepickerModule } from 'ngx-bootstrap'; - error thrown:
ERROR in Symbol BsDatepickerContainerComponent declared in /home/vs/Projects/testNGXIvy/node_modules/ngx-bootstrap/datepicker/themes/bs/bs-datepicker-container.component.d.ts is not exported from ngx-bootstrap (import into /home/vs/Projects/testNGXIvy/src/app/app.component.ts)
Looks like this is important issue, because a lot of users using just import from base module

@ludmilanesvitiy
Copy link
Contributor

Tested with "angularCompilerOptions": { "enableIvy": false, and true, tested imports from ngx-bootstrap and ngx-bootstrap/module, smoke tested demo site - looks good.

@Domainv Domainv merged commit 27639ea into development Jun 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-datepicker-ivy branch June 19, 2019 13:02
BsCustomDatesViewComponent,

..._exports
Copy link

@Splaktar Splaktar Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you open (or find) an issue against ngcc with Ivy to support the spread operator?

Copy link
Contributor Author

@Domainv Domainv Jul 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It already fixed, I checked it on angular 8.1.2
angular/angular#29835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngx-bootstrap isn't working with ivy
3 participants