-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datepicker): add ivy support #5268
Conversation
fd7da10
to
fb89f24
Compare
Codecov Report
@@ Coverage Diff @@
## development #5268 +/- ##
============================================
Coverage 51.04% 51.04%
============================================
Files 3 3
Lines 96 96
Branches 17 17
============================================
Hits 49 49
Misses 37 37
Partials 10 10 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## development #5268 +/- ##
============================================
Coverage 51.04% 51.04%
============================================
Files 3 3
Lines 96 96
Branches 17 17
============================================
Hits 49 49
Misses 37 37
Partials 10 10 Continue to review full report at Codecov.
|
1aac3f2
to
167350c
Compare
|
1e64d30
to
b99d197
Compare
Tested with "angularCompilerOptions": { "enableIvy": false, and true, tested imports from ngx-bootstrap and ngx-bootstrap/module, smoke tested demo site - looks good. |
BsCustomDatesViewComponent, | ||
|
||
..._exports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you open (or find) an issue against ngcc with Ivy to support the spread operator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already fixed, I checked it on angular 8.1.2
angular/angular#29835
Steps to reproduce:
ng new hello-ivy --enable-ivy
npm i
npm i ngx-bootstrap@next
npm run build
Closes #5257
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.