chore: upgrade react-native-shake to v5 #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3396 +/- ##
=======================================
Coverage 81.22% 81.22%
=======================================
Files 636 636
Lines 22290 22290
Branches 4024 4025 +1
=======================================
Hits 18104 18104
Misses 4124 4124
Partials 62 62
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The breaking change is only in the syntax of the shake subscription https://github.com/Doko-Demo-Doa/react-native-shake#usage. Unfortunately the newest version overrides the fix for xcode 12 compatibility so i added a patch.
Test plan
This flow is covered by e2e tests
Related issues
Backwards compatibility
Y