Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused walletConnectV1Enabled remote config #4924

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

kathaypacific
Copy link
Collaborator

@kathaypacific kathaypacific commented Feb 16, 2024

Description

As the title

Test plan

n/a

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d70e8e) 85.25% compared to head (04eee1d) 85.24%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4924      +/-   ##
==========================================
- Coverage   85.25%   85.24%   -0.01%     
==========================================
  Files         712      712              
  Lines       29229    29230       +1     
  Branches     5088     5087       -1     
==========================================
- Hits        24919    24918       -1     
- Misses       4067     4069       +2     
  Partials      243      243              
Files Coverage Δ
src/app/reducers.ts 22.82% <ø> (ø)
src/app/saga.ts 73.06% <ø> (ø)
src/app/selectors.ts 94.23% <ø> (-0.11%) ⬇️
src/firebase/firebase.ts 38.49% <ø> (ø)
src/firebase/remoteConfigValuesDefaults.ts 100.00% <ø> (ø)
src/redux/migrations.ts 97.23% <100.00%> (+<0.01%) ⬆️
src/redux/store.ts 79.36% <ø> (ø)
src/walletConnect/saga.ts 58.56% <100.00%> (ø)
test/schemas.ts 89.57% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d70e8e...04eee1d. Read the comment docs.

Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@kathaypacific kathaypacific enabled auto-merge (squash) February 16, 2024 15:49
@kathaypacific kathaypacific merged commit 236d15b into main Feb 16, 2024
16 checks passed
@kathaypacific kathaypacific deleted the kathy/remove-wc-v1 branch February 16, 2024 22:46
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
…#4924)

### Description

As the title

### Test plan

n/a

### Related issues

- Fixes RET-878

### Backwards compatibility

Y

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [x] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants