fix: new wallets only created with english mnemonics #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5064 +/- ##
=======================================
Coverage 85.55% 85.56%
=======================================
Files 723 723
Lines 29448 29439 -9
Branches 5078 5074 -4
=======================================
- Hits 25195 25189 -6
+ Misses 4020 4017 -3
Partials 233 233
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
finnian0826
reviewed
Mar 8, 2024
src/web3/saga.ts
Outdated
| let mnemonic: string = yield* call( | ||
| generateMnemonic, | ||
| mnemonicBitLength, | ||
| MnemonicLanguages.english, |
There was a problem hiding this comment.
Can this just be set to mnemonicLanguage? since it is set as english in the lines above.
finnian0826
approved these changes
Mar 8, 2024
1 build increased size
Celo (test) 1.80.0 (145)
|
| Item | Install Size Change |
|---|---|
| 📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
| 📝 background@3x.jpg | ⬆️ 368.6 kB |
| 📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
| 📝 background@2x.jpg | ⬆️ 176.1 kB |
| 📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
View Treemap
🛸 Powered by Emerge Tools
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description Wallets created when the users language was set to Spanish or Portuguese had mnemonics that were in Spanish or Portuguese. This causes interoperability issues for Valora users who wish to try other wallets: [Slack Thread](https://valora-app.slack.com/archives/C02KBT0DAHJ/p1709917662991769). ### Test plan - Tested locally on iOS - Unit tests updated ### Related issues N/A ### Backwards compatibility Yes - Users with Spanish and Portuguese mnemonics are still able to restore into Valora. ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wallets created when the users language was set to Spanish or Portuguese had mnemonics that were in Spanish or Portuguese. This causes interoperability issues for Valora users who wish to try other wallets: Slack Thread.
Test plan
Related issues
N/A
Backwards compatibility
Yes - Users with Spanish and Portuguese mnemonics are still able to restore into Valora.
Network scalability
N/A