-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jumpstart): execute reclaim transaction #5126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dievazqu
changed the title
Happy path almost working
feat(escrow): Executing reclaim transaction.
Mar 19, 2024
…the fetch status fails
kathaypacific
changed the title
feat(escrow): Executing reclaim transaction.
feat(jumpstart): Executing reclaim transaction.
Mar 28, 2024
kathaypacific
changed the title
feat(jumpstart): Executing reclaim transaction.
feat(jumpstart): executing reclaim transaction
Mar 28, 2024
kathaypacific
changed the title
feat(jumpstart): executing reclaim transaction
feat(jumpstart): execute reclaim transaction
Mar 28, 2024
kathaypacific
approved these changes
Mar 28, 2024
1 build increased size
Celo (test) 1.81.0 (146)
|
Item | Install Size Change |
---|---|
📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
📝 background@3x.jpg | ⬆️ 368.6 kB |
📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
📝 background@2x.jpg | ⬆️ 176.1 kB |
📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
🛸 Powered by Emerge Tools
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 28, 2024
chriskeating603
pushed a commit
that referenced
this pull request
Mar 28, 2024
### Description This PR implements the actual call to the blockchain to execute the reclaim. It also implements the error handling. ### Test plan Successful reclaim: https://github.com/valora-inc/wallet/assets/20150449/d474908b-e738-4340-ad77-54dcaf7f391c Reclaim status fetch error: https://github.com/valora-inc/wallet/assets/20150449/8ddf298f-4d94-44f2-9905-6fd909c48592 Reclaim error: https://github.com/valora-inc/wallet/assets/20150449/67c1d2b5-b772-4911-99c8-961330e01a73 ### Related issues - Fixes RET-1003 ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [Y] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added) ### Demo Happy path https://github.com/valora-inc/wallet/assets/12504748/ff782b85-3045-4cba-bedd-c376f181d3ee Error when fetching the status https://github.com/valora-inc/wallet/assets/12504748/799c5849-000e-4770-8fe8-d8a6d95ba0bf --------- Co-authored-by: Kathy Luo <kathyluo18@gmail.com>
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description This PR implements the actual call to the blockchain to execute the reclaim. It also implements the error handling. ### Test plan Successful reclaim: https://github.com/valora-inc/wallet/assets/20150449/d474908b-e738-4340-ad77-54dcaf7f391c Reclaim status fetch error: https://github.com/valora-inc/wallet/assets/20150449/8ddf298f-4d94-44f2-9905-6fd909c48592 Reclaim error: https://github.com/valora-inc/wallet/assets/20150449/67c1d2b5-b772-4911-99c8-961330e01a73 ### Related issues - Fixes RET-1003 ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [Y] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added) ### Demo Happy path https://github.com/valora-inc/wallet/assets/12504748/ff782b85-3045-4cba-bedd-c376f181d3ee Error when fetching the status https://github.com/valora-inc/wallet/assets/12504748/799c5849-000e-4770-8fe8-d8a6d95ba0bf --------- Co-authored-by: Kathy Luo <kathyluo18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the actual call to the blockchain to execute the reclaim. It also implements the error handling.
Test plan
Successful reclaim:
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-03-28.at.13.51.05.mp4
Reclaim status fetch error:
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-03-28.at.13.53.36.mp4
Reclaim error:
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-03-28.at.13.54.43.mp4
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will:
Demo
Happy path
https://github.com/valora-inc/wallet/assets/12504748/ff782b85-3045-4cba-bedd-c376f181d3ee
Error when fetching the status
https://github.com/valora-inc/wallet/assets/12504748/799c5849-000e-4770-8fe8-d8a6d95ba0bf