Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jumpstart): execute reclaim transaction #5126

Merged
merged 83 commits into from
Mar 28, 2024
Merged

Conversation

dievazqu
Copy link
Contributor

@dievazqu dievazqu commented Mar 19, 2024

Description

This PR implements the actual call to the blockchain to execute the reclaim. It also implements the error handling.

Test plan

Successful reclaim:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-03-28.at.13.51.05.mp4

Reclaim status fetch error:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-03-28.at.13.53.36.mp4

Reclaim error:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-03-28.at.13.54.43.mp4

Related issues

Backwards compatibility

Y

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • [Y] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Demo

Happy path
https://github.com/valora-inc/wallet/assets/12504748/ff782b85-3045-4cba-bedd-c376f181d3ee

Error when fetching the status
https://github.com/valora-inc/wallet/assets/12504748/799c5849-000e-4770-8fe8-d8a6d95ba0bf

@dievazqu dievazqu changed the title Happy path almost working feat(escrow): Executing reclaim transaction. Mar 19, 2024
@dievazqu dievazqu marked this pull request as ready for review March 19, 2024 07:04
@kathaypacific kathaypacific changed the title feat(escrow): Executing reclaim transaction. feat(jumpstart): Executing reclaim transaction. Mar 28, 2024
@kathaypacific kathaypacific changed the title feat(jumpstart): Executing reclaim transaction. feat(jumpstart): executing reclaim transaction Mar 28, 2024
@kathaypacific kathaypacific changed the title feat(jumpstart): executing reclaim transaction feat(jumpstart): execute reclaim transaction Mar 28, 2024
Base automatically changed from diego/reclaim-functionality to main March 28, 2024 13:10
Copy link

emerge-tools bot commented Mar 28, 2024

1 build increased size

Name Version Download Change Install Change Approval
⚠️ Celo (test)
org.celo.mobile.test
1.81.0 (146) 26.7 MB ⬆️ 2.4 MB (9.76%) 63.6 MB ⬆️ 2.7 MB (4.44%) N/A

Celo (test) 1.81.0 (146)
org.celo.mobile.test

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 2.7 MB (4.44%)
Total download size change: ⬆️ 2.4 MB (9.76%)

Largest size changes

Item Install Size Change
📝 splashBackground@3x.jpg ⬆️ 600.2 kB
📝 background@3x.jpg ⬆️ 368.6 kB
📝 boost-rewards@3x.png ⬆️ 188.4 kB
📝 background@2x.jpg ⬆️ 176.1 kB
📝 boost-rewards@2x.png ⬆️ 90.1 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

@kathaypacific kathaypacific added this pull request to the merge queue Mar 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 28, 2024
@kathaypacific kathaypacific added this pull request to the merge queue Mar 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 28, 2024
@kathaypacific kathaypacific added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 8678ced Mar 28, 2024
16 checks passed
@kathaypacific kathaypacific deleted the diego/reclaim-viem branch March 28, 2024 15:52
chriskeating603 pushed a commit that referenced this pull request Mar 28, 2024
### Description

This PR implements the actual call to the blockchain to execute the
reclaim. It also implements the error handling.

### Test plan

Successful reclaim:


https://github.com/valora-inc/wallet/assets/20150449/d474908b-e738-4340-ad77-54dcaf7f391c


Reclaim status fetch error:


https://github.com/valora-inc/wallet/assets/20150449/8ddf298f-4d94-44f2-9905-6fd909c48592


Reclaim error:


https://github.com/valora-inc/wallet/assets/20150449/67c1d2b5-b772-4911-99c8-961330e01a73



### Related issues

- Fixes RET-1003

### Backwards compatibility

Y

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [Y] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)

### Demo

Happy path

https://github.com/valora-inc/wallet/assets/12504748/ff782b85-3045-4cba-bedd-c376f181d3ee

Error when fetching the status

https://github.com/valora-inc/wallet/assets/12504748/799c5849-000e-4770-8fe8-d8a6d95ba0bf

---------

Co-authored-by: Kathy Luo <kathyluo18@gmail.com>
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
### Description

This PR implements the actual call to the blockchain to execute the
reclaim. It also implements the error handling.

### Test plan

Successful reclaim:


https://github.com/valora-inc/wallet/assets/20150449/d474908b-e738-4340-ad77-54dcaf7f391c


Reclaim status fetch error:


https://github.com/valora-inc/wallet/assets/20150449/8ddf298f-4d94-44f2-9905-6fd909c48592


Reclaim error:


https://github.com/valora-inc/wallet/assets/20150449/67c1d2b5-b772-4911-99c8-961330e01a73



### Related issues

- Fixes RET-1003

### Backwards compatibility

Y

### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [Y] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)

### Demo

Happy path

https://github.com/valora-inc/wallet/assets/12504748/ff782b85-3045-4cba-bedd-c376f181d3ee

Error when fetching the status

https://github.com/valora-inc/wallet/assets/12504748/799c5849-000e-4770-8fe8-d8a6d95ba0bf

---------

Co-authored-by: Kathy Luo <kathyluo18@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants