Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jumpstart): prevent possibility of sending multiple transactions #5133

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

kathaypacific
Copy link
Collaborator

Description

As the title - prevent triggering the send action again while there is a transaction inflight by disabling the button while loading.

Test plan

n/a

Related issues

n/a

Backwards compatibility

Y

Network scalability

Y

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.57%. Comparing base (2f60f03) to head (672f185).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5133      +/-   ##
==========================================
- Coverage   85.57%   85.57%   -0.01%     
==========================================
  Files         729      729              
  Lines       29827    29828       +1     
  Branches     5144     5145       +1     
==========================================
  Hits        25525    25525              
- Misses       4066     4067       +1     
  Partials      236      236              
Files Coverage Δ
src/jumpstart/JumpstartSendConfirmation.tsx 96.15% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f60f03...672f185. Read the comment docs.

Copy link
Contributor

@dievazqu dievazqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kathaypacific kathaypacific added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 192d702 Mar 21, 2024
16 checks passed
@kathaypacific kathaypacific deleted the kathy/fix-jumpstart-deposit-loading branch March 21, 2024 08:19
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
…alora-inc#5133)

### Description

As the title - prevent triggering the send action again while there is a
transaction inflight by disabling the button while loading.

### Test plan

n/a

### Related issues

n/a

### Backwards compatibility

Y

### Network scalability

Y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants