Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jumpstart): update jumpstart recipient button UI #5181

Merged
merged 1 commit into from
Mar 28, 2024
Merged

chore(jumpstart): update jumpstart recipient button UI #5181

merged 1 commit into from
Mar 28, 2024

Conversation

kathaypacific
Copy link
Collaborator

Description

As the title - design here

Test plan

Simulator Screenshot - iPhone 14 Pro - 2024-03-28 at 16 49 10

Related issues

n/a

Backwards compatibility

Y

Network scalability

Y

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (94ea0c4) to head (0918f87).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5181      +/-   ##
==========================================
- Coverage   85.78%   85.78%   -0.01%     
==========================================
  Files         745      744       -1     
  Lines       30217    30207      -10     
  Branches     5210     5213       +3     
==========================================
- Hits        25923    25913      -10     
  Misses       4057     4057              
  Partials      237      237
Files Coverage Δ
src/components/SelectRecipientButton.tsx 100.00% <100.00%> (ø)
src/send/SelectRecipientButtons.tsx 93.81% <100.00%> (+0.87%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ea0c4...0918f87. Read the comment docs.

bakoushin
bakoushin approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@bakoushin bakoushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@kathaypacific kathaypacific added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 836ba87 Mar 28, 2024
16 checks passed
@kathaypacific kathaypacific deleted the kathy/jumpstart-select-ui branch March 28, 2024 21:06
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
@kathaypacific @shottah
chore(jumpstart): update jumpstart recipient button UI (valora-inc#5181)
74aa9b8 
### Description

As the title - design
[here](https://www.figma.com/file/6sJ4fCxCptTybHB6ZZ7Pqi/Escrow-Feature?node-id=2986%3A1807&mode=dev)

### Test plan

![Simulator Screenshot - iPhone 14 Pro - 2024-03-28 at 16 49
10](https://github.com/valora-inc/wallet/assets/20150449/925b9fe7-c3d5-49f2-b80d-18c42174c918)


### Related issues

n/a

### Backwards compatibility

Y

### Network scalability

Y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakoushin bakoushin bakoushin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kathaypacific @bakoushin