feat(points): Add initial points activity feed saga #5206
Conversation
jophish
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5206 +/- ##
==========================================
+ Coverage 85.81% 85.82% +0.01%
==========================================
Files 744 747 +3
Lines 30455 30521 +66
Branches 5274 5283 +9
==========================================
+ Hits 26134 26195 +61
- Misses 4082 4087 +5
Partials 239 239
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Looking great! it'd be great to work with Kayla to decide if the activity history should be persisted between points homepage visits and between app sessions.
if we should clear the history every time the user comes into the bottom sheet, i think we should consider whether redux and saga is the most straightforward approach. naively i think we'd have a less complex solution with useAsyncCallback...
if we should show previously fetched history, we might want to think about how much history is sensible to keep in redux. currently we just keep putting more stuff there, but that's not good for memory usage. we could consider something like the homefeed (keep only the first page or X items?)
1 build increased size
Celo (test) 1.82.0 (147)
|
| Item | Install Size Change |
|---|---|
| main.jsbundle | ⬆️ 8.2 kB |
🛸 Powered by Emerge Tools
### Description For [RET-1032](https://linear.app/valora/issue/RET-1032/[wallet-fake-backend]-points-activity-history). Adds in saga/data fetching for points history. (I also started implementing the bottom sheet itself but left it out here in the interest of size, see videos below. Will get out a PR after this as a fast follow.) See the related PR for the backend `/getHistory` endpoint [here](https://github.com/valora-inc/points-functions/pull/23). ### Test plan Unit and manual tested. See videos below. #### Happy path (no error) https://github.com/valora-inc/wallet/assets/569401/3fd18685-8f27-4b09-b1b9-227eb1fc92de #### Error https://github.com/valora-inc/wallet/assets/569401/72838322-f454-4df0-b49d-e838f984d0d2 ### Related issues - Part of [RET-1032](https://linear.app/valora/issue/RET-1032/[wallet-fake-backend]-points-activity-history). ### Backwards compatibility Yes. ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [x] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added) --------- Co-authored-by: Kathy Luo <kathyluo18@gmail.com>
Description
For RET-1032. Adds in saga/data fetching for points history. (I also started implementing the bottom sheet itself but left it out here in the interest of size, see videos below. Will get out a PR after this as a fast follow.)
See the related PR for the backend
/getHistoryendpoint here.Test plan
Unit and manual tested. See videos below.
Happy path (no error)
points-history-happy-path-2024-04-04_15.43.35.mp4
Error
points-history-error-path-2024-04-04_15.44.12.mp4
Related issues
Backwards compatibility
Yes.
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: