Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(send): allow entering amount in fiat #5213

Merged
merged 11 commits into from
Apr 11, 2024
Merged

feat(send): allow entering amount in fiat #5213

merged 11 commits into from
Apr 11, 2024

Conversation

satish-ravi
Copy link
Contributor

@satish-ravi satish-ravi commented Apr 8, 2024

Description

Allows entering fiat amount with upto 2 decimal places. Automatically adds grouping separators to input

Test plan

Unit tests. Tested manually on iOS and android with different separators

Simulator.Screen.Recording.-.iPhone.13.-.2024-04-10.at.12.34.41.mp4

Related issues

Backwards compatibility

Yes

Network scalability

N/A

Copy link

sentry-io bot commented Apr 8, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/send/EnterAmount.tsx

Function Unhandled Issue
EnterAmount Error: No prepared transactions found handleRevie...
Event Count: 1 Affected Users: 2

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 94.05941% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 85.81%. Comparing base (c3d6657) to head (92b8e81).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5213      +/-   ##
==========================================
+ Coverage   85.77%   85.81%   +0.04%     
==========================================
  Files         744      744              
  Lines       30351    30411      +60     
  Branches     5240     5264      +24     
==========================================
+ Hits        26033    26097      +64     
+ Misses       4079     4075       -4     
  Partials      239      239              
Files Coverage Δ
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/jumpstart/JumpstartEnterAmount.tsx 93.02% <100.00%> (+0.08%) ⬆️
src/send/SendEnterAmount.tsx 93.75% <100.00%> (ø)
src/send/types.ts 100.00% <ø> (ø)
src/send/EnterAmount.tsx 96.37% <93.54%> (+2.34%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d6657...92b8e81. Read the comment docs.

@satish-ravi satish-ravi marked this pull request as ready for review April 10, 2024 19:47
Copy link

emerge-tools bot commented Apr 10, 2024

1 build increased size

Name Version Download Change Install Change Approval
⚠️ Celo (test)
org.celo.mobile.test
1.82.0 (147) 26.8 MB ⬆️ 2.4 MB (9.72%) 63.7 MB ⬆️ 2.7 MB (4.42%) N/A

Celo (test) 1.82.0 (147)
org.celo.mobile.test

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 2.7 MB (4.42%)
Total download size change: ⬆️ 2.4 MB (9.72%)

Largest size changes

Item Install Size Change
📝 splashBackground@3x.jpg ⬆️ 600.2 kB
📝 background@3x.jpg ⬆️ 368.6 kB
📝 boost-rewards@3x.png ⬆️ 188.4 kB
📝 background@2x.jpg ⬆️ 176.1 kB
📝 boost-rewards@2x.png ⬆️ 90.1 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

@satish-ravi satish-ravi added this pull request to the merge queue Apr 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2024
@satish-ravi satish-ravi added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 7e7c5f3 Apr 11, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/act-1142 branch April 11, 2024 00:00
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
### Description

Allows entering fiat amount with upto 2 decimal places. Automatically
adds grouping separators to input

### Test plan

Unit tests. Tested manually on iOS and android with different separators



https://github.com/valora-inc/wallet/assets/5062591/e4f1f522-3572-4d80-83a5-b4683f17bbb6



### Related issues

- Fixes ACT-1142

### Backwards compatibility

Yes

### Network scalability

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants