-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(send): allow entering amount in fiat #5213
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/send/EnterAmount.tsx
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5213 +/- ##
==========================================
+ Coverage 85.77% 85.81% +0.04%
==========================================
Files 744 744
Lines 30351 30411 +60
Branches 5240 5264 +24
==========================================
+ Hits 26033 26097 +64
+ Misses 4079 4075 -4
Partials 239 239
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
1 build increased size
Celo (test) 1.82.0 (147)
|
Item | Install Size Change |
---|---|
📝 splashBackground@3x.jpg | ⬆️ 600.2 kB |
📝 background@3x.jpg | ⬆️ 368.6 kB |
📝 boost-rewards@3x.png | ⬆️ 188.4 kB |
📝 background@2x.jpg | ⬆️ 176.1 kB |
📝 boost-rewards@2x.png | ⬆️ 90.1 kB |
🛸 Powered by Emerge Tools
### Description Allows entering fiat amount with upto 2 decimal places. Automatically adds grouping separators to input ### Test plan Unit tests. Tested manually on iOS and android with different separators https://github.com/valora-inc/wallet/assets/5062591/e4f1f522-3572-4d80-83a5-b4683f17bbb6 ### Related issues - Fixes ACT-1142 ### Backwards compatibility Yes ### Network scalability N/A
Description
Allows entering fiat amount with upto 2 decimal places. Automatically adds grouping separators to input
Test plan
Unit tests. Tested manually on iOS and android with different separators
Simulator.Screen.Recording.-.iPhone.13.-.2024-04-10.at.12.34.41.mp4
Related issues
Backwards compatibility
Yes
Network scalability
N/A