chore(points): use points config from redux rather than Statsig #5232
Conversation
| </ScrollView> | ||
| <BottomSheet | ||
| snapPoints={['50%']} |
There was a problem hiding this comment.
this is a personal preference but the vertical spaces triggered me, particularly between the bottom of the button and the bottom of the screen. i think it's better to let the bottom sheet size itself (if we need to increase the height, we should add space above the button)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5232 +/- ##
=======================================
Coverage 85.89% 85.89%
=======================================
Files 745 745
Lines 30434 30473 +39
Branches 5276 5282 +6
=======================================
+ Hits 26142 26176 +34
- Misses 4055 4061 +6
+ Partials 237 236 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
src/points/ActivityCardSection.tsx
Outdated
| const pointsConfig = getDynamicConfigParams(DynamicConfigs[StatsigDynamicConfigs.POINTS_CONFIG]) | ||
|
|
||
| function makeSection(pointsMetadata: PointsMetadata): React.ReactNode { | ||
| function makeSection(pointsMetadata: PointsMetadata, sectionNumber: number): React.ReactNode { |
There was a problem hiding this comment.
nit: is that an index? wdyt about naming it sectionIndex?
…ra-inc#5232) ### Description This PR: - remove the statsig dynamic config - use the redux selectors to provide config to existing UI components - update unit tests (some were removed because the scenarios are tested in the saga and selector) ### Test plan n/a ### Related issues - Related to RET-1044 ### Backwards compatibility Y ### Network scalability Y --------- Co-authored-by: Joseph Bergeron <jophish126@gmail.com> Co-authored-by: Joe Bergeron <jbergero@alum.mit.edu>
Description
This PR:
Test plan
n/a
Related issues
Backwards compatibility
Y
Network scalability
Y