Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(statsig): disable uninitialized logs on e2e tests #5233

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

satish-ravi
Copy link
Contributor

Description

Logs are flooded with these when running E2E tests because the sdk runs in local mode and returns the default values

Test plan

Manual

Related issues

N/A

Backwards compatibility

N/A

Network scalability

N/A

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (d27051e) to head (68eae88).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5233      +/-   ##
==========================================
- Coverage   85.81%   85.81%   -0.01%     
==========================================
  Files         744      744              
  Lines       30452    30453       +1     
  Branches     5274     5274              
==========================================
  Hits        26133    26133              
- Misses       4080     4081       +1     
  Partials      239      239              
Files Coverage Δ
src/statsig/index.ts 98.52% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27051e...68eae88. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit 45d35d6 Apr 12, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/statsig-log-fix branch April 12, 2024 20:14
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
…c#5233)

Logs are flooded with these when running E2E tests because the sdk runs
in local mode and returns the default values

Manual

N/A

N/A

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants