feat(points): add loading and error states for loading config #5253
Conversation
kathaypacific
changed the base branch from
kathy/points-config-switch
to
kathy/points-config-redux
kathaypacific
changed the base branch from
kathy/points-config-redux
to
kathy/points-config-switch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5253 +/- ##
=======================================
Coverage 85.89% 85.89%
=======================================
Files 745 745
Lines 30434 30487 +53
Branches 5276 5288 +12
=======================================
+ Hits 26142 26188 +46
- Misses 4055 4063 +8
+ Partials 237 236 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -2244,6 +2244,15 @@ | |||
| "points": { | |||
| "title": "Valora Points", | |||
| "activity": "Activity", | |||
| "loading": { | |||
| "title": "Gathering your points", | |||
| "description": "We're in the process of tallying up your points, hang tight" | |||
There was a problem hiding this comment.
nit: should this copy not have a period, unlike the error description? 👀 i see that this matches the figma designs but not sure if it's intentional.
There was a problem hiding this comment.
i'll double check! i think the copy is not final yet though, seems reasonable to assume that we'll do a pass through before releasing this
…-inc#5253) ### Description As the title. ### Test plan The load is done on app start so we shouldn't see a loading state unless there was an error and the user tries again. Added an artificial delay for these videos. Error state: https://github.com/valora-inc/wallet/assets/20150449/d15a4b5a-b5cb-4bb0-bb07-91a15f2c6975 Success state: https://github.com/valora-inc/wallet/assets/20150449/ec5a50cf-2873-4d4b-8dbc-f41aa1240b8b ### Related issues - Fixes RET-1044 ### Backwards compatibility Y ### Network scalability Y --------- Co-authored-by: Joseph Bergeron <jophish126@gmail.com> Co-authored-by: Joe Bergeron <jbergero@alum.mit.edu>
Description
As the title.
Test plan
The load is done on app start so we shouldn't see a loading state unless there was an error and the user tries again. Added an artificial delay for these videos.
Error state:
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-04-15.at.10.13.49.mp4
Success state:
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2024-04-15.at.10.14.22.mp4
Related issues
Backwards compatibility
Y
Network scalability
Y