fix(cico): fix crash on bottom sheet when token list is empty #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5390 +/- ##
=======================================
Coverage 86.09% 86.09%
=======================================
Files 737 737
Lines 30016 30016
Branches 5143 5143
=======================================
+ Hits 25841 25842 +1
+ Misses 3948 3947 -1
Partials 227 227
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MuckT
approved these changes
May 6, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
…-inc#5390) ### Description Crashes when token list is empty, which attempts to render a 0 outside of a `<Text>` component ### Test plan Unit tests, manually by emptying token list ### Related issues N/A ### Backwards compatibility Yes ### Network scalability N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crashes when token list is empty, which attempts to render a 0 outside of a
<Text>componentTest plan
Unit tests, manually by emptying token list
Related issues
N/A
Backwards compatibility
Yes
Network scalability
N/A