Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): Add UI skeleton of earn collect #5411

Merged
merged 7 commits into from
May 14, 2024
Merged

feat(earn): Add UI skeleton of earn collect #5411

merged 7 commits into from
May 14, 2024

Conversation

jh2oman
Copy link
Contributor

@jh2oman jh2oman commented May 13, 2024

Description

Figma

TODO in followup PR:

  • unit tests
  • hook into Earn flow
  • fetch real data for rewards, apy
  • prepare transactions, estimate gas, execute transactions
  • loading, disabled, error states.

Screenshot_20240513_235415

Test plan

Unit tests in followup PR

Related issues

https://linear.app/valora/issue/ACT-1180/wallet-earn-collect-review-screen

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (258f77a) to head (1cc0dab).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5411      +/-   ##
==========================================
- Coverage   86.16%   86.15%   -0.01%     
==========================================
  Files         745      745              
  Lines       30333    30334       +1     
  Branches     5186     5186              
==========================================
  Hits        26135    26135              
- Misses       3970     3971       +1     
  Partials      228      228              
Files Coverage Δ
src/navigator/Screens.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 258f77a...1cc0dab. Read the comment docs.

locales/base/translation.json Outdated Show resolved Hide resolved
src/earn/EarnCollectScreen.tsx Outdated Show resolved Hide resolved
src/earn/EarnCollectScreen.tsx Outdated Show resolved Hide resolved
src/earn/EarnCollectScreen.tsx Outdated Show resolved Hide resolved
@jh2oman jh2oman added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit af4fd52 May 14, 2024
17 checks passed
@jh2oman jh2oman deleted the earn-collect-ui branch May 14, 2024 18:23
shottah pushed a commit to zed-io/kolektivo that referenced this pull request May 15, 2024
### Description


[Figma](https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Stablecoin-Enablement?node-id=2472-14441&m=dev)

TODO in followup PR: 
* unit tests
* hook into Earn flow
* fetch real data for rewards, apy
* prepare transactions, estimate gas, execute transactions
* loading, disabled, error states.


![Screenshot_20240513_235415](https://github.com/valora-inc/wallet/assets/8432644/45d90907-3b46-471a-8e7b-bbdff640fa05)


### Test plan

Unit tests in followup PR

### Related issues


https://linear.app/valora/issue/ACT-1180/wallet-earn-collect-review-screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants