-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(earn): Add UI skeleton of earn collect #5411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5411 +/- ##
==========================================
- Coverage 86.16% 86.15% -0.01%
==========================================
Files 745 745
Lines 30333 30334 +1
Branches 5186 5186
==========================================
Hits 26135 26135
- Misses 3970 3971 +1
Partials 228 228
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
satish-ravi
reviewed
May 13, 2024
satish-ravi
approved these changes
May 14, 2024
shottah
pushed a commit
to zed-io/kolektivo
that referenced
this pull request
May 15, 2024
### Description [Figma](https://www.figma.com/design/E1rC3MG74qEg5V4tvbeUnU/Stablecoin-Enablement?node-id=2472-14441&m=dev) TODO in followup PR: * unit tests * hook into Earn flow * fetch real data for rewards, apy * prepare transactions, estimate gas, execute transactions * loading, disabled, error states. ![Screenshot_20240513_235415](https://github.com/valora-inc/wallet/assets/8432644/45d90907-3b46-471a-8e7b-bbdff640fa05) ### Test plan Unit tests in followup PR ### Related issues https://linear.app/valora/issue/ACT-1180/wallet-earn-collect-review-screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Figma
TODO in followup PR:
Test plan
Unit tests in followup PR
Related issues
https://linear.app/valora/issue/ACT-1180/wallet-earn-collect-review-screen