Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): add function for fetching aave rewards #5422

Merged
merged 3 commits into from
May 17, 2024

Conversation

satish-ravi
Copy link
Contributor

Description

As the title

Test plan

Unit tests

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.24%. Comparing base (db7459a) to head (50d1834).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5422      +/-   ##
==========================================
- Coverage   86.24%   86.24%   -0.01%     
==========================================
  Files         750      751       +1     
  Lines       30556    30593      +37     
  Branches     5216     5219       +3     
==========================================
+ Hits        26354    26385      +31     
- Misses       3974     3980       +6     
  Partials      228      228              
Files Coverage Δ
src/abis/AaveIncentivesV3.ts 100.00% <100.00%> (ø)
src/web3/networkConfig.ts 100.00% <100.00%> (ø)
test/values.ts 100.00% <100.00%> (ø)
src/earn/poolInfo.ts 88.23% <89.65%> (+1.87%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db7459a...50d1834. Read the comment docs.

src/web3/networkConfig.ts Show resolved Hide resolved
src/abis/AaveIncentivesV3.ts Outdated Show resolved Hide resolved
src/earn/poolInfo.ts Show resolved Hide resolved
src/earn/poolInfo.ts Outdated Show resolved Hide resolved
@satish-ravi satish-ravi added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit d7d9ae8 May 17, 2024
16 checks passed
@satish-ravi satish-ravi deleted the satish/act-1180-fetch-aave-rewards branch May 17, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants