Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): add pending transaction types #5434

Merged
merged 4 commits into from
May 20, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

Description

Use the correct pending transaction type for earn txs. Also refactors existing pending tx types to avoid duplication

Test plan

Unit tests, manual

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.33%. Comparing base (a7efc6d) to head (48ac2dd).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5434      +/-   ##
==========================================
- Coverage   86.34%   86.33%   -0.01%     
==========================================
  Files         755      755              
  Lines       30942    30942              
  Branches     5281     5281              
==========================================
- Hits        26716    26715       -1     
- Misses       3999     4000       +1     
  Partials      227      227              
Files Coverage Δ
src/earn/saga.ts 93.93% <ø> (ø)
src/transactions/actions.ts 90.90% <ø> (ø)
src/transactions/types.ts 97.72% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7efc6d...48ac2dd. Read the comment docs.

Base automatically changed from satish/act-1180-submit-withdraw-tx to main May 20, 2024 20:03
# Conflicts:
#	src/earn/saga.test.ts
#	src/earn/saga.ts
@MuckT MuckT enabled auto-merge May 20, 2024 20:16
@MuckT MuckT added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 85a9d0c May 20, 2024
16 checks passed
@MuckT MuckT deleted the satish/earn-standby-txs branch May 20, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants