Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(earn): navigation to enter amount on deposit more tap #5439

Merged
merged 2 commits into from
May 21, 2024

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented May 21, 2024

Description

Hooks up the deposit more button on the Earn cta to navigation and analytics.

Test plan

  • Tested locally on iOS
  • Unit tests added

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (86c921d) to head (0fb22ab).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5439      +/-   ##
==========================================
+ Coverage   86.30%   86.31%   +0.01%     
==========================================
  Files         756      756              
  Lines       31173    31185      +12     
  Branches     5340     5347       +7     
==========================================
+ Hits        26903    26917      +14     
+ Misses       4038     4035       -3     
- Partials      232      233       +1     
Files Coverage Δ
src/analytics/Events.tsx 100.00% <100.00%> (ø)
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/earn/EarnActivePool.tsx 94.00% <100.00%> (+2.33%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c921d...0fb22ab. Read the comment docs.

@MuckT MuckT enabled auto-merge May 21, 2024 08:54
Copy link
Collaborator

@kathaypacific kathaypacific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MuckT MuckT added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 5946f19 May 21, 2024
16 checks passed
@MuckT MuckT deleted the tomm/earn-deposit-more branch May 21, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants